I had this problem on another machine a few weeks ago, researched it, fixed it, and apparently I've already forgotten what to do. When doom upgrade fails, it's likely to be because someone changed the name of a branch in the repository. The easiest thing to do is to delete ~/.emacs.d/.local/straight/repos. Run doom sync to rebuild the repositories, and everything should work fine.